docs: add specific tensor shape annotations to metrics.py - #310
docs: add specific tensor shape annotations to metrics.py#310Junaid1206 wants to merge 4 commits into
Conversation
|
@Junaid1206 thank you, could you please revert to the original template. The current one is missing some bits. |
|
Updated the description to include the full original template with all checklist sections. Thanks for pointing that out, @sadamov |
|
The description still looks very strange, could you have another look at the template. |
|
Hi @joeloskarsson, I apologize for the formatting issues in the previous update. I have now carefully re-applied the original repository template, ensuring all Markdown sections (headings, checklists, and bullet points) are correctly formatted and rendered. Could you please take a look and let me know if this version meets the project's standards? Thank you for your patience. Best regards |
|
Hi @sadamov @joeloskarsson, I hope you're doing well. I have updated the PR description and fixed the formatting issues as per the repository template a few days ago. Please let me know if any further changes are required or if this is ready for review. Thank you! Best Regards, |
|
To now consolidate all docstring improvements in one place, I think it would be best to add these as suggestions there (I think you already started looking at this :)). So I'll close this in favor of that workflow. |
Summary
This PR adds comprehensive Google-style docstrings and explicit tensor shape annotations to the
metrics.pymodule.Changes
wmse,wmae,nll, andcrps_gauss.(..., N, d_state)) to clarify broadcasting behavior and batch dimensions.mask_and_reduce_metricto clearly explain spatial masking and grid/variable reduction logic.Motivation and Context
Following the discussion in #252, this PR addresses a documentation gap in the evaluation module.
The evaluation logic is central to understanding how model performance is measured, particularly with respect to:
This PR focuses purely on documentation improvements and does not modify functionality.
Dependencies
None.
Type of Change
Checklist Before Requesting Review
Author Checklist After Review
Checklist for Assignee