Add probabilistic scaffold to ARModel via config-driven output_mode and ensemble_size - #228
Closed
Panchadip-128 wants to merge 1 commit into
Closed
Add probabilistic scaffold to ARModel via config-driven output_mode and ensemble_size#228Panchadip-128 wants to merge 1 commit into
Panchadip-128 wants to merge 1 commit into
Conversation
Member
|
this looks like the same changes as #229, can we close this @Panchadip-128 ? Please make a draft PR in future if your work isn't ready for us to look at yet :) |
Author
|
Thank you for your feedback, and apologies for any confusion caused by the duplicate PR. I appreciate your guidance and will make sure to submit draft PRs for work-in-progress in the future. Please feel free to close this PR so we can consolidate discussion on other PR. |
Collaborator
|
closed as per discussion, work is being done here: #229 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on PR)
Describe your changes
This PR introduces a minimal probabilistic scaffold in ARModel by making probabilistic configuration fully config-driven.
Specifically, the model now reads output_mode and ensemble_size from config.training, enabling future ensemble-based probabilistic forecasting extensions while preserving existing deterministic behavior.
Additionally, a validation guard for output_mode is added and a minor typo (time_step_int_unit) is corrected to time_step_unit.
The change is intentionally lightweight and does not modify training, inference, or loss computation logic.
< Please also include relevant motivation and context. >
The probabilistic forecasting roadmap requires an architectural scaffold to support ensemble outputs without introducing breaking changes. Moving probabilistic control into the configuration layer aligns with Neural-LAM’s design philosophy and enables incremental extensions such as ensemble sampling and probabilistic losses.
< List any dependencies that are required for this change. >
No new dependencies were introduced
Issue Link
N/A — foundational scaffold for probabilistic forecasting support
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee