Skip to content

Include full time information in TOA radiation calculation #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leifdenby merged 5 commits into from
Feb 27, 2026
Merged

Include full time information in TOA radiation calculation #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f16681b
refine toa radiation calc to include min and s
observingClouds Nov 3, 2025
5864860
document changes
observingClouds Nov 3, 2025
d37c8c2
fix PR number
observingClouds Nov 3, 2025
d9e452a
Merge branch 'main' into feat/improve_toa_resolution
observingClouds Feb 8, 2026
2a32f8a
Merge branch 'main' into feat/improve_toa_resolution
observingClouds Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [unreleased](https://github.com/mllam/mllam-data-prep/compare/v0.7.0...HEAD)

### Changed
- consider full time information for derived calculation of TOA radiation [\#84](https://github.com/mllam/mllam-data-prep/pull/84) @observingClouds

### Fixes
- fix bug where coordinate selection of an unshared dimension isn't applied to subsequent ouput variables when an output variable without this dimension is processed before the others [\#90](https://github.com/mllam/mllam-data-prep/pull/90) @zweihuehner & @leifdenby

Expand Down
4 changes: 2 additions & 2 deletions mllam_data_prep/ops/derive_variable/physical_field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ def calculate_toa_radiation(lat, lon, time):
# Different handling if xr.DataArray or datetime object
if isinstance(time, xr.DataArray):
day = time.dt.dayofyear
hour_utc = time.dt.hour
hour_utc = time.dt.hour + time.dt.minute / 60 + time.dt.second / 3600
elif isinstance(time, datetime.datetime):
day = time.timetuple().tm_yday
hour_utc = time.hour
hour_utc = time.hour + time.minute / 60 + time.second / 3600
else:
raise TypeError(
"Expected an instance of xr.DataArray or datetime object,"
Expand Down