Deepseek: skip first N evals#891
Open
denys-fridman wants to merge 3 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd like to propose a change in the eval schedule of deepseek - the current setup is problematic because the validation dataset is small (1024 samples) so it's very inefficient to run eval at scale larger than the number of validation samples. The training GBS is set at 15k+, and since the training dataset is enormous, even large systems can support that. On the other hand, since the validation dataset is 1k samples, the largest GBS that makes sense is 1k. To handle the disconnect you have to either duplicate the dataset multiple times to maintain the same GBS for training/validation - reducing the scaling efficiency by doing redundant work; or implement a different parallelisation schema for validation - something that nobody does because it adds overheads.
Here's the proposal:
The validation starts after
N(GBS) = GBS*FLOOR(42+24576/GBS)samples - this gives us 2-3 spare evaluations before we hit the RCP min, and ~4 before we hit the RCP avg. The equation (slope) was obtained by fitting a straight line to the RCP avg at different GBS. The bias was obtained empirically by lowering it enough to be 2-3 evaluations below the lowest RCP point at all GBS - to make sure the reduction of thetotal_eval_cost/total_train_costis approximately 90%. The green line on the plot shows the function.Related PRs: