fix: refine cursor positioning using pixel-based calculations#9
Open
mkslanc wants to merge 4 commits into
Open
fix: refine cursor positioning using pixel-based calculations#9mkslanc wants to merge 4 commits into
mkslanc wants to merge 4 commits into
Conversation
|
This does not work when editor position on screen changes (try collapsing sidebar), and does not work on multiselect, since each selection has it's own selection object. Also updateSelectionPixelConversion method is pretty bad, we need only to add fontmetrics to selection, we should not dynamically add methods to classes. It is also possible to add fontmetrics directly to session, that way tmpsel at https://github.com/ajaxorg/ace/blob/master/src/multi_select.js#L504 will get correct fontmetrics automatically. |
nightwing
reviewed
May 28, 2026
…ed text-to-pixel accuracy and update related cursor positioning logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts) and its references:Open kitchen-sink @ dc57d2d5a823c447836621c9286862790aea6d31
Open kitchen-sink @ f8231bc63aa6239bb0768857f1fa38c929908337
Open kitchen-sink @ 2ac3f77c83b2e874497182793f85358fa3624819
Open kitchen-sink @ 02c76f982a9c569a65538885ebbac8377a6e6e17