Skip to content

fix: refine cursor positioning using pixel-based calculations#9

Open
mkslanc wants to merge 4 commits into
varchar3-fixes1from
varchar3-desiredposition
Open

fix: refine cursor positioning using pixel-based calculations#9
mkslanc wants to merge 4 commits into
varchar3-fixes1from
varchar3-desiredposition

Conversation

@mkslanc

@mkslanc mkslanc commented May 26, 2026

Copy link
Copy Markdown
Owner

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Open kitchen-sink @ dc57d2d5a823c447836621c9286862790aea6d31

Open kitchen-sink @ f8231bc63aa6239bb0768857f1fa38c929908337

Open kitchen-sink @ 2ac3f77c83b2e874497182793f85358fa3624819

Open kitchen-sink @ 02c76f982a9c569a65538885ebbac8377a6e6e17

@nightwing

Copy link
Copy Markdown

This does not work when editor position on screen changes (try collapsing sidebar), and does not work on multiselect, since each selection has it's own selection object.
I think there is no need to introduce desiredPixelPos, instead of that we should update desired column the way we do when rendering markers, and save as column, (that would keep correct position even when font size changes).

Also updateSelectionPixelConversion method is pretty bad, we need only to add fontmetrics to selection, we should not dynamically add methods to classes.

It is also possible to add fontmetrics directly to session, that way tmpsel at https://github.com/ajaxorg/ace/blob/master/src/multi_select.js#L504 will get correct fontmetrics automatically.

Comment thread src/selection.js Outdated
…ed text-to-pixel accuracy and update related cursor positioning logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants