fix(upgrade): copy package files in inline fallback#431
Open
NgoQuocViet2001 wants to merge 2 commits intomksglu:nextfrom
Open
fix(upgrade): copy package files in inline fallback#431NgoQuocViet2001 wants to merge 2 commits intomksglu:nextfrom
NgoQuocViet2001 wants to merge 2 commits intomksglu:nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctx_upgradeinline fallback read the clonedpackage.json#fileslist instead of copying a hard-coded subset.mcp.jsonplaceholder write in the inline fallback so upgraded plugin caches retain${CLAUDE_PLUGIN_ROOT}binpayload in upgrade copiesFixes #429
Test plan
pnpm exec vitest run tests/core/cli.test.ts -t "statusline bin|inline fallback copies package files"pnpm run typecheckgit diff --checkpnpm exec vitest run tests/core/cli.test.ts— local Windows/pnpm run reaches 114 passing tests, then SQLite adapter tests fail becausebetter-sqlite3native bindings are unavailable after pnpm ignored build scripts (better-sqlite3,esbuild).