🎨 Palette: Map accessibility props for Input component#224
Conversation
Co-authored-by: mknoufi <209227354+mknoufi@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
CodeAnt AI is reviewing your PR. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:S
|
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| ref={ref} | ||
| accessibilityLabel={label} | ||
| aria-invalid={hasError} | ||
| aria-errormessage={error} |
There was a problem hiding this comment.
Suggestion: aria-errormessage must reference the ID of an existing error element, but this passes the human-readable error text directly. As a result, assistive tech cannot resolve the relationship and the error announcement will fail; generate a stable ID, pass that ID to aria-errormessage, and assign the same ID (via nativeID/id) to the rendered error text node. [api mismatch]
Severity Level: Critical 🚨
- ❌ Screen readers cannot programmatically associate input error text.
- ⚠️ Error messages not reliably announced for invalid fields.
- ⚠️ Accessibility of web forms using Input degraded.Steps of Reproduction ✅
1. Open `frontend/src/components/ui/Input.tsx` and note the `TextInput` definition at
lines 116-120 where `aria-errormessage={error}` is set (line 120) but the error text
element below at lines 137-140 (`<Text>{error}</Text>`) has no `id` or `nativeID`.
2. Open `frontend/src/components/Input.stories.tsx` and inspect the `AllStates` story at
lines 21-40 where an `Input` is rendered with `error="This field is required"` (lines
29-32), causing the `error` prop to be passed into `frontend/src/components/ui/Input.tsx`.
3. Run the Storybook or app on a web target using a screen reader, navigate to the “With
Error” input from `AllStates` in `Input.stories.tsx`, and trigger validation so `error` is
non-empty and rendered.
4. Inspect the rendered DOM for the input: the `TextInput` element has
`aria-errormessage="This field is required"` (from
`frontend/src/components/ui/Input.tsx:120`), but no element in the DOM has a matching
`id`/`nativeID`, so assistive technology cannot resolve the ARIA relationship and will not
programmatically associate the field with its error message.
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** frontend/src/components/ui/Input.tsx
**Line:** 120:120
**Comment:**
*Api Mismatch: `aria-errormessage` must reference the ID of an existing error element, but this passes the human-readable error text directly. As a result, assistive tech cannot resolve the relationship and the error announcement will fail; generate a stable ID, pass that ID to `aria-errormessage`, and assign the same ID (via `nativeID`/`id`) to the rendered error text node.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
|
CodeAnt AI finished reviewing your PR. |
1 participant
User description
💡 What: Added
accessibilityLabel,aria-invalid, andaria-errormessageprops to the nativeTextInputinside the reusableInputcomponent.🎯 Why: The component accepted
labelanderrorprops but only rendered them visually. Screen reader users were unable to hear the input's context or its error state programmatically.♿ Accessibility: Ensures full screen reader support for any form field using this reusable
Inputcomponent.PR created automatically by Jules for task 6620535165197338498 started by @mknoufi
CodeAnt-AI Description
Make reusable input fields announce labels and errors to screen readers
What Changed
Impact
✅ Clearer form field announcements✅ Fewer missed input errors✅ Better screen reader form navigation💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.