Skip to content

Bump wasm-bindgen from 0.2.122 to 0.2.123 in /core#9

Merged
mkh-user merged 1 commit into
mainfrom
dependabot/cargo/core/wasm-bindgen-0.2.123
Jun 12, 2026
Merged

Bump wasm-bindgen from 0.2.122 to 0.2.123 in /core#9
mkh-user merged 1 commit into
mainfrom
dependabot/cargo/core/wasm-bindgen-0.2.123

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 12, 2026

Copy link
Copy Markdown
Contributor

Bumps wasm-bindgen from 0.2.122 to 0.2.123.

Release notes

Sourced from wasm-bindgen's releases.

0.2.123

Added

  • Added the maxAge attribute to the CookieInit dictionary in web-sys, matching the current Cookie Store API specification. #5169

  • The js-sys futures codegen opt-in can now also be enabled via the WASM_BINDGEN_USE_JS_SYS=1 environment variable, in addition to --cfg=wasm_bindgen_use_js_sys. This works on stable when --target is in use, where Cargo does not propagate the cfg to host proc-macros. #5164

Changed

  • JsOption<T> now treats only undefined as empty, aligning it with TypeScript's strict T | undefined semantics and with Option<T>'s wire shape (Noneundefined). Previously is_empty, as_option, into_option, unwrap, expect, unwrap_or_default, and unwrap_or_else treated both null and undefined as absent; JS null is now a distinct present value. The impl<T> UpcastFrom<Null> for JsOption<T> is removed (Undefined still models absence), and the Debug/Display absent placeholder changed from "null" to "undefined". Code relying on null → None should return undefined from the JS side, or check explicitly with val.as_option().filter(|v| !v.is_null()). #5170

Fixed

  • Removed invalid js_sys::Array<T> to js_sys::ArrayTuple<(...)> upcasts. ArrayTuple encodes a fixed tuple arity, while a plain JavaScript array does not prove that arity statically.

  • Fixed incorrect variance in &mut reference upcasting. &mut T upcasts were covariant in the pointee, so a &mut T could be widened to a &mut of a supertype and used to write back a value the original type would not accept, leaving a reference whose static type no longer matches the value it points to. Mutable references are now invariant in their pointee: &mut T only upcasts to &mut Target when both Target: UpcastFrom<T> and T: UpcastFrom<Target> hold. This rejects the invalid widening but is a breaking change for callers that relied on widening &mut references. #5176

  • Fixed WASI targets (wasm32-wasip1/wasm32-wasip2) emitting unresolved __wbindgen_placeholder__ imports, which broke component linking. The codegen and runtime gates now exclude target_os = "wasi" (restoring the pre-0.2.115 stub behavior), including the panic = "unwind" paths in wasm-bindgen-futures. #5175

... (truncated)

Changelog

Sourced from wasm-bindgen's changelog.

0.2.123

Added

  • Added the maxAge attribute to the CookieInit dictionary in web-sys, matching the current Cookie Store API specification. #5169

  • The js-sys futures codegen opt-in can now also be enabled via the WASM_BINDGEN_USE_JS_SYS=1 environment variable, in addition to --cfg=wasm_bindgen_use_js_sys. This works on stable when --target is in use, where Cargo does not propagate the cfg to host proc-macros. #5164

Changed

  • JsOption<T> now treats only undefined as empty, aligning it with TypeScript's strict T | undefined semantics and with Option<T>'s wire shape (Noneundefined). Previously is_empty, as_option, into_option, unwrap, expect, unwrap_or_default, and unwrap_or_else treated both null and undefined as absent; JS null is now a distinct present value. The impl<T> UpcastFrom<Null> for JsOption<T> is removed (Undefined still models absence), and the Debug/Display absent placeholder changed from "null" to "undefined". Code relying on null → None should return undefined from the JS side, or check explicitly with val.as_option().filter(|v| !v.is_null()). #5170

Fixed

  • Removed invalid js_sys::Array<T> to js_sys::ArrayTuple<(...)> upcasts. ArrayTuple encodes a fixed tuple arity, while a plain JavaScript array does not prove that arity statically.

  • Fixed incorrect variance in &mut reference upcasting. &mut T upcasts were covariant in the pointee, so a &mut T could be widened to a &mut of a supertype and used to write back a value the original type would not accept, leaving a reference whose static type no longer matches the value it points to. Mutable references are now invariant in their pointee: &mut T only upcasts to &mut Target when both Target: UpcastFrom<T> and T: UpcastFrom<Target> hold. This rejects the invalid widening but is a breaking change for callers that relied on widening &mut references. #5176

  • Fixed WASI targets (wasm32-wasip1/wasm32-wasip2) emitting unresolved __wbindgen_placeholder__ imports, which broke component linking. The codegen and runtime gates now exclude target_os = "wasi" (restoring the pre-0.2.115 stub behavior), including the panic = "unwind" paths in wasm-bindgen-futures.

... (truncated)

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Jun 12, 2026
@socket-security

socket-security Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedcargo/​wasm-bindgen@​0.2.1238110093100100

View full report

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates wasm-bindgen from 0.2.122 to 0.2.123. While the project remains up to Codacy standards, the update introduces breaking changes that have not been explicitly addressed in the source code. Specifically, the change in how 'null' is handled in JsOption and the new invariance rules for mutable reference upcasting may lead to logic regressions or compilation errors that are not captured by a simple lockfile update.

About this PR

  • The 0.2.123 release contains breaking changes despite being a patch-level bump in the 0.2.x series. Specifically, the change to JsOption (handling 'null' as present) and the switch to invariance for mutable reference upcasting could break existing logic in /core. Please ensure these changes have been evaluated against the current codebase.

Test suggestions

  • Verify successful compilation of the /core project with wasm-bindgen 0.2.123
  • Audit and test any usages of JsOption to ensure compatibility with the change where 'null' is now treated as a present value rather than 'None'
  • Verify that code utilizing mutable reference upcasting remains valid under the new invariance rules
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify successful compilation of the /core project with wasm-bindgen 0.2.123
2. Audit and test any usages of JsOption to ensure compatibility with the change where 'null' is now treated as a present value rather than 'None'
3. Verify that code utilizing mutable reference upcasting remains valid under the new invariance rules

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

@mkh-user

Copy link
Copy Markdown
Owner

@dependabot rebase

Bumps [wasm-bindgen](https://github.com/wasm-bindgen/wasm-bindgen) from 0.2.122 to 0.2.123.
- [Release notes](https://github.com/wasm-bindgen/wasm-bindgen/releases)
- [Changelog](https://github.com/wasm-bindgen/wasm-bindgen/blob/main/CHANGELOG.md)
- [Commits](wasm-bindgen/wasm-bindgen@0.2.122...0.2.123)

---
updated-dependencies:
- dependency-name: wasm-bindgen
  dependency-version: 0.2.123
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/cargo/core/wasm-bindgen-0.2.123 branch from 66f4d42 to 87776a3 Compare June 12, 2026 10:41
@mkh-user mkh-user merged commit d9b9846 into main Jun 12, 2026
22 checks passed
@mkh-user mkh-user deleted the dependabot/cargo/core/wasm-bindgen-0.2.123 branch June 12, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant