Bump wasm-bindgen from 0.2.122 to 0.2.123 in /core#9
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR updates wasm-bindgen from 0.2.122 to 0.2.123. While the project remains up to Codacy standards, the update introduces breaking changes that have not been explicitly addressed in the source code. Specifically, the change in how 'null' is handled in JsOption and the new invariance rules for mutable reference upcasting may lead to logic regressions or compilation errors that are not captured by a simple lockfile update.
About this PR
- The 0.2.123 release contains breaking changes despite being a patch-level bump in the 0.2.x series. Specifically, the change to JsOption (handling 'null' as present) and the switch to invariance for mutable reference upcasting could break existing logic in /core. Please ensure these changes have been evaluated against the current codebase.
Test suggestions
- Verify successful compilation of the /core project with wasm-bindgen 0.2.123
- Audit and test any usages of JsOption to ensure compatibility with the change where 'null' is now treated as a present value rather than 'None'
- Verify that code utilizing mutable reference upcasting remains valid under the new invariance rules
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify successful compilation of the /core project with wasm-bindgen 0.2.123
2. Audit and test any usages of JsOption to ensure compatibility with the change where 'null' is now treated as a present value rather than 'None'
3. Verify that code utilizing mutable reference upcasting remains valid under the new invariance rules
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
@dependabot rebase |
Bumps [wasm-bindgen](https://github.com/wasm-bindgen/wasm-bindgen) from 0.2.122 to 0.2.123. - [Release notes](https://github.com/wasm-bindgen/wasm-bindgen/releases) - [Changelog](https://github.com/wasm-bindgen/wasm-bindgen/blob/main/CHANGELOG.md) - [Commits](wasm-bindgen/wasm-bindgen@0.2.122...0.2.123) --- updated-dependencies: - dependency-name: wasm-bindgen dependency-version: 0.2.123 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
66f4d42 to
87776a3
Compare
Bumps wasm-bindgen from 0.2.122 to 0.2.123.
Release notes
Sourced from wasm-bindgen's releases.
... (truncated)
Changelog
Sourced from wasm-bindgen's changelog.
... (truncated)
Commits
861696aRelease 0.2.123 (#5188)c667a97fix: remove Upcast from Array to ArrayTuple (#5185)4f674f2fix: mutable reference variance (#5183)edb2c00Discover wasm64 main (#5181)bd27e9aFix unresolved wbindgen_placeholder imports on WASI targets (#5175)b49c851fix(cli-support): handle i64 (width-8) loads in the descriptor interpreter (#...bf5261aPolyfill WebAssembly.JSTag for legacy EH on Node 20+ (#5168)04e946eAllow opting into js-sys futures codegen via env var (#5164)cc60a51Reuse LazyCell in js-sys (#5172)0621e40JsOption: strict undefined-only emptiness (#5170)