Bump pyo3-build-config from 0.28.3 to 0.29.0 in /bindings/python#11
Conversation
Bumps [pyo3-build-config](https://github.com/pyo3/pyo3) from 0.28.3 to 0.29.0. - [Release notes](https://github.com/pyo3/pyo3/releases) - [Changelog](https://github.com/PyO3/pyo3/blob/main/CHANGELOG.md) - [Commits](PyO3/pyo3@v0.28.3...v0.29.0) --- updated-dependencies: - dependency-name: pyo3-build-config dependency-version: 0.29.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This pull request attempts to bump 'pyo3-build-config' from 0.28.3 to 0.29.0 to resolve security vulnerabilities and provide support for Python 3.15. While these are necessary improvements, the implementation is currently incomplete and will cause the build to fail.
In the PyO3 ecosystem, 'pyo3-build-config' and the main 'pyo3' crate are version-locked. The current changes update the build configuration without a corresponding update to the 'pyo3' or 'pyo3-ffi' dependencies. These must be updated in lock-step to ensure compatibility and successful compilation. The PR should not be merged until the main PyO3 dependencies are also bumped to 0.29.0.
About this PR
- The update to 'pyo3-build-config' 0.29.0 is missing a corresponding update to the 'pyo3' crate. Because these crates validate version parity during the build process, the current state of the PR will result in a 'version mismatch' error during compilation. Please update all related PyO3 dependencies to 0.29.0 simultaneously.
Test suggestions
- Verify that the Python bindings compile successfully with PyO3 0.29.0, ensuring the new requirement for direct pyo3/pyo3-ffi dependencies is met.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the Python bindings compile successfully with PyO3 0.29.0, ensuring the new requirement for direct pyo3/pyo3-ffi dependencies is met.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Bumps pyo3-build-config from 0.28.3 to 0.29.0.
Release notes
Sourced from pyo3-build-config's releases.
... (truncated)
Changelog
Sourced from pyo3-build-config's changelog.
... (truncated)
Commits
0f90242release: 0.29.0 (#6107)cd128eddoc: mention abi3t, python3t.dll, and abi3t_compat folder in FAQ (#6124)7e2ef18Avoid type checks in methods where CPython already guarantees the received ty...f930199docs: additional detail in migration guide for 0.29 (#6123)91ab0d1Enable Windows abi3t tests (#6106)fe0fdd5addPyLong*API (3.14+) (#6016)f41b1dfHang when reattaching after detach during shutdown (#6085)5ae66a8Fix double import on RustPython (#6122)ad4a510PyFunction: enable some extra tests with abi3 (#6118)c79ac0eci: Add test for minimum supported debug build of Python (#5852)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)