Skip to content

chore: decrease the multipart threshold #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joeldierkes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: decrease the multipart threshold #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/upload-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ import { toFile } from '../internal/to-file';
import { multipartFormRequestOptions } from '../internal/uploads';
import type { Fetch } from '../internal/builtin-types';

const DEFAULT_THRESHOLD = 100 * 1024 * 1024; // 100MB
const DEFAULT_THRESHOLD = 10 * 1024 * 1024; // 10MB
const DEFAULT_CONCURRENCY = 5;
const DEFAULT_PART_SIZE = 100 * 1024 * 1024; // 100MB per part
const MIN_PART_SIZE = 5 * 1024 * 1024; // 5MB minimum
const MIN_PART_SIZE = 1 * 1024 * 1024; // 1MB minimum

@cursor cursor Bot Mar 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error messages hardcode "5MB" but minimum is now 1MB

Medium Severity

Changing MIN_PART_SIZE to 1MB without updating the hardcoded "5MB" in the error messages on lines 75 and 79 produces contradictory output. For example, the error now reads "partSize must be at least 5MB (1048576 bytes)" — but 1048576 bytes is 1MB, not 5MB. The human-readable label and the interpolated byte value disagree, confusing users.

Additional Locations (2)
Fix in Cursor Fix in Web

const MAX_PART_COUNT = 10_000;

export interface PartUploadEvent {
Expand Down
Loading