Conversation
Owner
mivek
commented
May 29, 2026
mivek
commented
- Add getString(Locale, String) and getString(Locale, String, Object...) stateless overloads to Messages.java
- Make stateless overloads defensive (return key on MissingResourceException)
- Deprecate setLocale()/clearLocale() in favor of explicit Locale parameter
- Add toString(Locale) to all 15 enums and ~20 model/trend classes
- All existing toString() delegates to toString(Locale.getDefault()) for backward compat
- Synchronize all 8 locale bundles with English fallback for missing keys
- Keep legacy getString(String) throwing MissingResourceException for RemarkParser compatibility
- Update all setLocale-based tests to use toString(Locale) directly
- Add InternationalizationKeyCoverageTest to verify enum keys exist in base bundle
- Re-enable testLocaleContainsAllBaseKeys parameterized test
|
Please check on sonarcloud https://sonarcloud.io/project/pull_requests_list?id=io.github.mivek%3AmetarParser that the PR does not add any issue. |
- Add getString(Locale, String) and getString(Locale, String, Object...) stateless overloads to Messages.java - Make stateless overloads defensive (return key on MissingResourceException) - Deprecate setLocale()/clearLocale() in favor of explicit Locale parameter - Add toString(Locale) to all 15 enums and ~20 model/trend classes - All existing toString() delegates to toString(Locale.getDefault()) for backward compat - Synchronize all 8 locale bundles with English fallback for missing keys - Keep legacy getString(String) throwing MissingResourceException for RemarkParser compatibility - Update all setLocale-based tests to use toString(Locale) directly - Add InternationalizationKeyCoverageTest to verify enum keys exist in base bundle - Re-enable testLocaleContainsAllBaseKeys parameterized test
|
🎉 This PR is included in version 2.26.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.