Skip to content

Add WP_User_Query support for TiDB (SQL_CALC_FOUND_ROWS / FOUND_ROWS) #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabamnml wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add WP_User_Query support for TiDB (SQL_CALC_FOUND_ROWS / FOUND_ROWS) #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion wp/wp-content/plugins/tidb-compatibility/tidb-compatibility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,18 @@ public static function wtc_init() {
$wp_query->fw_clauses = $clauses;
return $clauses;
}, 999, 2 );

/**
* WP_User_Query (admin users list, etc.)
*/
add_filter( 'found_users_query', [ __CLASS__, 'wtc_add_found_users_query' ], 999, 2 );
add_filter( 'users_pre_query', function ( $results, \WP_User_Query $query ) {
$query->query_fields = self::wtc_remove_found_rows_query( $query->query_fields );
return $results;
}, 999, 2 );
}
public static function wtc_remove_found_rows_query( $sql ) {
return str_replace( ' SQL_CALC_FOUND_ROWS ', '', $sql );
return preg_replace( '/\bSQL_CALC_FOUND_ROWS\s+/i', '', $sql );
}
public static function wtc_add_found_rows_query( $sql, WP_Query $query ) {
global $wpdb;
Expand All @@ -51,5 +60,15 @@ public static function wtc_add_found_rows_query( $sql, WP_Query $query ) {
WHERE 1=1 $where
";
}
public static function wtc_add_found_users_query( $sql, WP_User_Query $query ) {
global $wpdb;
$has_distinct = stripos( $query->query_fields, 'DISTINCT' ) !== false;
$count = $has_distinct ? "COUNT( DISTINCT {$wpdb->users}.ID )" : 'COUNT(*)';
return "
SELECT $count
{$query->query_from}
{$query->query_where}
";
}
}
WTC_FIX_WP_SLOW_QUERY::wtc_init();