Added substep resetting#4
Open
dimitriye98 wants to merge 6 commits into
Open
Conversation
Made substeps reset when leaving a slide, and turn on when entering the slide in reverse
This reverts commit b253a1f.
Added a "impress-substep-[id]" similar to the “impress-on-[step]” indicator, but to the parent step instead of the general impress div.
Replaced my tab indents with the space indents used in the rest of the code.
Fixed a slight mistake in the reset code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it so when leaving a step, all the substeps deactivate, and if you enter a step from the back i.e. using the left arrow key, all the substeps reactivate before moving to the step. Thus, looping repeatedly through the presentation forwards will result in always encountering steps with entirely reset substeps, and looping repeatedly backwards will result in always encountering steps with entirely activated substeps.
Also added an "impress-substep-[substep id]" indicator similar to the "impress-on-[step id]" indicator for steps. However, the class is added to the parent step instead of the impress div. Substeps with no user-defined id will have the id "substep-[index]", just like with steps. This yields the slightly awkward indicator name "impress-substep-substep-[index]".