Skip to content

improve shuttle mode#142

Merged
amzoeee merged 8 commits into
mainfrom
zoe/shuttle-mode
Apr 7, 2026
Merged

improve shuttle mode#142
amzoeee merged 8 commits into
mainfrom
zoe/shuttle-mode

Conversation

@amzoeee

@amzoeee amzoeee commented Apr 6, 2026

Copy link
Copy Markdown
Member

unfortunately a little bit destructive on the math side.

note that the shooting logic is much simplified since we don't care as much about shot consistency and whatnot.

ATM there is no "will we shoot into hub" check

amzoeee added 3 commits April 5, 2026 22:26
unfortunately a little destructive w/ the generalization
@amzoeee

amzoeee commented Apr 6, 2026

Copy link
Copy Markdown
Member Author

augment review

@augmentcode

augmentcode Bot commented Apr 6, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR updates “shuttle mode” to aim at the nearest alliance corner and simplify the shuttle shooting flow.

Changes:

  • Reworks the driver left-trigger shuttle binding to pass translation joystick input into the shuttle command.
  • Adds dynamic shuttle shooter velocity + shuttle aiming suppliers in RobotCommandFactory.
  • Introduces shootForShuttle to gate feeding primarily on drivetrain angle + shooter speed, while keeping indexer/roller running.
  • Generalizes “shoot-on-the-fly” math in HubCalculations to target arbitrary field points and adds shuttle-corner targeting utilities.
  • Updates shuttle mechanism velocities so shuttle uses intake-like speeds for roller/indexer and shoot speed for column.
  • Adds TeleopConstants.CORNER_OFFSET to aim inside the field boundary for corner shuttle shots.

Technical Notes: Shuttle angle is computed field-relative with latency compensation and robot-velocity subtraction (SOTF-style) toward the closest corner (alliance-flipped).

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 4 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/main/java/frc/robot/utils/HubCalculations.java
Comment thread src/main/java/frc/robot/subsystems/RobotCommandFactory.java
Comment thread src/main/java/frc/robot/subsystems/RobotCommandFactory.java
Comment thread src/main/java/frc/robot/subsystems/RobotCommandFactory.java

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 3 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/main/java/frc/robot/subsystems/RobotCommandFactory.java
Comment thread src/main/java/frc/robot/subsystems/RobotCommandFactory.java
Comment thread src/main/java/frc/robot/utils/HubCalculations.java

@riley-jen riley-jen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amzoeee amzoeee merged commit 3e6905c into main Apr 7, 2026
1 check passed
@amzoeee amzoeee deleted the zoe/shuttle-mode branch April 7, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants