Skip to content

Remove 'src' from cleanup command in post_install.lua #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yeshan333 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove 'src' from cleanup command in post_install.lua #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cf01f5
Remove 'src' from cleanup command in post_install.lua
yeshan333 Apr 25, 2026
7287849
Update hooks/post_install.lua
yeshan333 Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hooks/post_install.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ function PLUGIN:PostInstall(ctx)
os.execute(string.format("rm -rf '%s/luarocks.tar.gz' '%s/luarocks-'*", sdkPath, sdkPath))
end

-- Clean up Lua source files (keep only bin, lib, include, man, share, luarocks)
local cleanCmd = string.format("cd '%s' && rm -rf src doc Makefile README install 2>/dev/null", sdkPath)
-- Clean up Lua source files (keep bin, lib, include, man, share, src, luarocks)
local cleanCmd = string.format("cd '%s' && rm -rf doc Makefile README install 2>/dev/null", sdkPath)

@gemini-code-assist gemini-code-assist Bot Apr 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment on line 113 is now outdated as it does not include src in the list of kept directories. Please update it to reflect that src is now preserved to maintain consistency between the code and its documentation.

Additionally, using %q in string.format is a more robust way to handle sdkPath in the shell command, as it automatically handles quoting and escaping for paths that might contain spaces or special characters (like single quotes).

    local cleanCmd = string.format("cd %q && rm -rf doc Makefile README install 2>/dev/null", sdkPath)

os.execute(cleanCmd)
end