fix(compiler): dedup fanned-out additive leaves in composite metrics - #251
Merged
Conversation
- Reuse the existing DISTINCT ON fanout-safe dedup (_build_deduped, moved to _helpers.py) in composite.py's ratio/weighted_avg leaf planning, which previously skipped it for additive measures - Add measure_aliases param so leaves alias to n/d instead of the measure's own name - Add regression tests: SQL structure + executed DuckDB numeric check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DISTINCT ONdedup for additive leaves that need a one_to_many/many_to_many join to reach the requested dimension, silently inflating the numerator/denominator (reported via a jaffle_shopavg_revenue_per_unit_soldquery grouped byproduct.name)._build_dedupedmoved fromsimple_additive.pyto the shared_helpers.pyand reused incomposite.py::_plan_leaf's additive+fanout branch, mirroring the existing simple-additive fanout protection.measure_aliasesparam so a composite leaf can alias its aggregate ton/dinstead of the measure's own name.Test plan
pytest tests/compiler/test_composable.py— new SQL-structure + executed-DuckDB numeric-correctness regression testspytest tests/— full suite greenruff check . && ruff format --check ./mypy canonic/avg_revenue_per_unit_soldnow matchesrevenue / units_soldexactly🤖 Generated with Claude Code