feat(compiler): aggregate fanned-out metric sources independently before combining - #249
Merged
Merged
Conversation
…ore combining - Pre-aggregate each metric's source at its own grain as a CTE and combine via FULL JOIN/CROSS JOIN, instead of raising FanoutUnsafe, when additive metrics span sources joined by a non-one_to_one relationship - Keep FanoutUnsafe for non-additive/semi-additive cross-source fanout - Add coverage for multi-leaf grouping, unreachable-dimension, and non-additive-still-blocked cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FanoutUnsafe, when additive metrics span sources joined by a non-one_to_one relationshipFanoutUnsafefor non-additive/semi-additive cross-source fanoutTest plan
pytest tests/compiler/test_simple_additive_multi_metric.py -vpytest tests/ -x --tb=short(1985 passed)ruff check . && ruff format --check .mypy canonic/compiler/strategies/simple_additive.py