fix(compiler): plan joins across all requested metrics' sources - #247
Merged
Conversation
mischuh
commented
Jul 27, 2026
mischuh
commented
Owner
- include every metric's source in join planning, not just dimensions/filters, fixing missing JOINs (BinderException) when metrics span multiple sources
- raise FanoutUnsafe for non-one_to_one cross-source metric joins, since the existing dedup/flat-select emission would otherwise silently corrupt the aggregate
- include every metric's source in join planning, not just dimensions and filters, fixing missing JOINs when metrics span multiple sources - raise FanoutUnsafe for non-one_to_one cross-source metric joins, since the dedup/flat-select emission would otherwise silently corrupt the aggregate Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mischuh
force-pushed
the
fix/compiler-cross-source-metric-joins
branch
from
July 27, 2026 19:27
0627999 to
f5c5bd2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.