fix(compiler): scope per-metric population_filter/guardrails when com… - #240
Merged
Conversation
…-metric queries Compiling several single-kind metrics in one query (e.g. --metrics total_income,total_expenses,net_cashflow) folded every requested metric's population_filter and mandatory_filter guardrails into one shared WHERE clause covering the flat SELECT they all share. When two metrics carried different restrictions, the combined WHERE could never match any row, so every aggregate came back NULL. With more than one metric requested, each metric's own filter/guardrail conditions now scope only its own aggregate via conditional aggregation (CASE WHEN); single-metric queries are unaffected (still a plain shared WHERE, identical SQL to before).
mischuh
force-pushed
the
fix/multi-metric-simple-additive-null
branch
from
July 23, 2026 06:47
2b5f56b to
d0a86f5
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…piling multiple simple metrics together
Compiling several single-kind metrics in one query (e.g. --metrics total_income,total_expenses,net_cashflow) folded every requested metric's population_filter and mandatory_filter guardrails into one shared WHERE clause covering the flat SELECT they all share. When two metrics carried different restrictions, the combined WHERE could never match any row, so every aggregate came back NULL. With more than one metric requested, each metric's own filter/guardrail conditions now scope only its own aggregate via conditional aggregation (SUM(CASE WHEN ... THEN ... END)); single-metric queries are unaffected (still a plain shared WHERE, byte-identical SQL to before).