fix(compiler): thread each ratio component's own population_filter in… - #238
Merged
Conversation
…to its leaf For composable_post_agg metrics (ratio/weighted_avg), _compile_composite only ever read the ratio metric's own population_filter and applied it to both numerator and denominator leaves. A population_filter declared on a component measure itself (e.g. total_repair_cost or damage_count) was silently ignored, so the divisor and dividend were compiled unfiltered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to its leaf
For composable_post_agg metrics (ratio/weighted_avg), _compile_composite only ever read the ratio metric's own population_filter and applied it to both numerator and denominator leaves. A population_filter declared on a component measure itself (e.g. total_repair_cost or damage_count) was silently ignored, so the divisor and dividend were compiled unfiltered.