You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I understand correctly, it is not quite the same: The goal here is to produce an alternative constructor to the type config, in order to be able to bypass the usage of Cmdliner (not convenient for me at the moment).
From what I see, your PR extends the Cmdliner constructor with a new arbitrary bind address parameter.
I am however fine with waiting on your PR to be merged to include your changes to this PR, since our changes clashes nonetheless. :-)
Edit: my bad, I misread your sentence: it is not the same, but our changes are related indeed! If you feel like incorporating the config constructor outside of Cmdliner from my changes into your branch, feel free to do it! Or I will wait for your work to be merged and fix this branch myself. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to our previous conversation offline.
This PR aims to add a simple constructor for the
configtype inPrometheus_unix, so that we do not have to solely rely on theCmdlinerbased facility.This is probably not quite nice enough, let me know if I can adjust it in any way. :)