tar_lwt_unix gzip functions - #149
Draft
reynir wants to merge 2 commits into
Draft
Conversation
reynir
force-pushed
the
duplicate-gz
branch
from
September 11, 2024 13:45
75ebc96 to
e6751c8
Compare
Member
Author
|
I rewrote Tar_lwt_unix.create to use Tar.out. An issue I haven't solved is how to ensure the dir_handle is closed if there is an error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is WIP to address #148. It implements
fold_gzandextract_gz, andcreate_gzis stubbed out. I noticecreatedoesn't useTar.torTar.outfor writing the archive. It's probably an oversight when write support was added. I will look into that.