Skip to content

fix warning#17

Open
geertijewski wants to merge 1 commit into
minube:masterfrom
geertijewski:issue-14
Open

fix warning#17
geertijewski wants to merge 1 commit into
minube:masterfrom
geertijewski:issue-14

Conversation

@geertijewski

Copy link
Copy Markdown

solution by @515orestis #14

@nono303

nono303 commented Dec 1, 2020

Copy link
Copy Markdown

Hi,
Thanks @geertijewski for this PR!
with php8 count on uncountable object trigger an error and not a warning
testing var with is_countable before count is now mandatory

@geertijewski

Copy link
Copy Markdown
Author

Hi @nono303 thanks I was not aware of this. However I already removed the invocation of count() and replaced it with is_array(), so unless I missed something I don't think I need to amend this Pull Request

@nono303

nono303 commented Dec 3, 2020

Copy link
Copy Markdown

Hi @geertijewski,
you don't need to amend the PR
is_countable is nicer before count but require >=7.3 https://php.watch/versions/7.3#new-is_countable-function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants