feat: add --check flag for config and connectivity validation#29
Merged
Conversation
Validates config, log file, ClickHouse connection, database/table existence, and column mapping against actual table schema. Exits with code 1 on failure. Integration tests cover: all checks passing, missing column detection, and non-existent database detection. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Columns mapped to enrichment sources (prefixed with _) are resolved at runtime and don't exist in the ClickHouse table. The check now skips them and reports the count separately. Added integration test for enrichment columns passing validation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ClickHouse rejects connections to non-existent databases at the auth level, so connect() fails before the DB check runs. Changed test to verify non-existent table detection instead, which exercises the full check pipeline (connection OK → database OK → table FAIL). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates config, log file, ClickHouse connection, database/table existence, and column mapping against actual table schema. Exits with code 1 on failure.
Integration tests cover: all checks passing, missing column detection, and non-existent database detection.