-
Notifications
You must be signed in to change notification settings - Fork 80
feat: add consolereadonly canned policy #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kannappanr
merged 2 commits into
minio:main
from
allanrogerr:feat/consolereadonly-policy
Apr 22, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| // Copyright (c) 2015-2026 MinIO, Inc. | ||
| // | ||
| // This file is part of MinIO Object Storage stack | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU Affero General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU Affero General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU Affero General Public License | ||
| // along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| package policy | ||
|
|
||
| import "testing" | ||
|
|
||
| func findDefaultPolicy(name string) (Policy, bool) { | ||
| for _, p := range DefaultPolicies { | ||
| if p.Name == name { | ||
| return p.Definition, true | ||
| } | ||
| } | ||
| return Policy{}, false | ||
| } | ||
|
|
||
| func TestDefaultPolicyReadOnly(t *testing.T) { | ||
| p, ok := findDefaultPolicy("readonly") | ||
| if !ok { | ||
| t.Fatal("readonly default policy not found") | ||
| } | ||
| if err := p.Validate(); err != nil { | ||
| t.Fatalf("readonly policy invalid: %v", err) | ||
| } | ||
|
|
||
| allowed := NewActionSet(GetBucketLocationAction, GetObjectAction) | ||
| denied := NewActionSet(CreateUserAdminAction) | ||
|
|
||
| var sawAllow, sawDeny bool | ||
| for _, s := range p.Statements { | ||
| switch s.Effect { | ||
| case Allow: | ||
| sawAllow = true | ||
| if !s.Actions.Equals(allowed) { | ||
| t.Errorf("readonly Allow actions = %v, want %v", s.Actions, allowed) | ||
| } | ||
| case Deny: | ||
| sawDeny = true | ||
| if !s.Actions.Equals(denied) { | ||
| t.Errorf("readonly Deny actions = %v, want %v", s.Actions, denied) | ||
| } | ||
| } | ||
| } | ||
| if !sawAllow || !sawDeny { | ||
| t.Errorf("readonly missing Allow/Deny statement: allow=%v deny=%v", sawAllow, sawDeny) | ||
| } | ||
| } | ||
|
|
||
| func TestDefaultPolicyConsoleReadOnly(t *testing.T) { | ||
| p, ok := findDefaultPolicy("consolereadonly") | ||
| if !ok { | ||
| t.Fatal("consolereadonly default policy not found") | ||
| } | ||
| if err := p.Validate(); err != nil { | ||
| t.Fatalf("consolereadonly policy invalid: %v", err) | ||
| } | ||
|
|
||
| allowed := NewActionSet(GetBucketLocationAction, GetObjectAction, ListBucketAction) | ||
| denied := NewActionSet(CreateUserAdminAction) | ||
|
|
||
| var sawAllow, sawDeny bool | ||
| for _, s := range p.Statements { | ||
| switch s.Effect { | ||
| case Allow: | ||
| sawAllow = true | ||
| if !s.Actions.Equals(allowed) { | ||
| t.Errorf("consolereadonly Allow actions = %v, want %v", s.Actions, allowed) | ||
| } | ||
| case Deny: | ||
| sawDeny = true | ||
| if !s.Actions.Equals(denied) { | ||
| t.Errorf("consolereadonly Deny actions = %v, want %v", s.Actions, denied) | ||
| } | ||
| } | ||
| } | ||
| if !sawAllow || !sawDeny { | ||
| t.Errorf("consolereadonly missing Allow/Deny statement: allow=%v deny=%v", sawAllow, sawDeny) | ||
| } | ||
| } | ||
|
|
||
| func TestDefaultPolicyConsoleReadOnlyAllowsListBucket(t *testing.T) { | ||
| p, ok := findDefaultPolicy("consolereadonly") | ||
| if !ok { | ||
| t.Fatal("consolereadonly default policy not found") | ||
| } | ||
| args := Args{ | ||
| AccountName: "testuser", | ||
| Action: ListBucketAction, | ||
| BucketName: "bucket1", | ||
| } | ||
| if !p.IsAllowed(args) { | ||
| t.Error("consolereadonly should allow s3:ListBucket") | ||
| } | ||
|
|
||
| ro, ok := findDefaultPolicy("readonly") | ||
| if !ok { | ||
| t.Fatal("readonly default policy not found") | ||
| } | ||
| if ro.IsAllowed(args) { | ||
| t.Error("readonly should NOT allow s3:ListBucket (sanity check)") | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.