fix(validator): guard legacy ensure_schema alters for fresh DBs (#120) - #230
Open
RealDiligent wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
docs
Contributor
Author
RealDiligent
force-pushed
the
fix/critical-issue-ensure-schema-fresh-db-v2
branch
from
July 30, 2026 15:34
f843b50 to
633821e
Compare
Contributor
Author
|
Rebased onto current |
Contributor
Author
|
CI green + MERGEABLE after rebase. Ready for maintainer merge. |
…uter#120) _drop_not_null_if_needed treated absent columns as NOT NULL and still ALTERed them; legacy team_name/benchmark UPDATEs were also unguarded. Gate both on _column_exists so fresh-DB startup works. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #120 (resubmits closed #121).
On a fresh Postgres DB,
ensure_schema()crashed withUndefinedColumnbecause it ran unguardedALTER COLUMN ... DROP NOT NULL/ legacyUPDATEs for columns that are now ORM@propertyaccessors (artifact_name,team_name, etc.).This PR gates those legacy statements on
information_schema.columnsso first-run startup works, while legacy DBs still migrate.Test plan
validator/tests/test_ensure_schema.py— fresh path + legacy back-filltest-validatorgreen