Skip to content

Refactor <Notifications /> with hooks#57

Open
edumoreira1506 wants to merge 1 commit into
minhtranite:masterfrom
edumoreira1506:refactor-notifications
Open

Refactor <Notifications /> with hooks#57
edumoreira1506 wants to merge 1 commit into
minhtranite:masterfrom
edumoreira1506:refactor-notifications

Conversation

@edumoreira1506

Copy link
Copy Markdown

Related to issue #54

@chitgoks

Copy link
Copy Markdown

is the author still active? this is the best design of notifications i have come across and hopefully these pull requests will be merged. those warning messages take up a huge chunk in the console.

@edumoreira1506

Copy link
Copy Markdown
Author

I don't know if actor is active, but I hope that yes.

@chitgoks

Copy link
Copy Markdown

or you could fork it?

@tjrexer

tjrexer commented Mar 17, 2020

Copy link
Copy Markdown

I forked this repo and have taken ownership from the original owner in npm. I've published an update to remove the unsafe components. If you would like this to be reviewed, please submit a PR into tjrexer/react-notifications:next.

@chitgoks

chitgoks commented Mar 18, 2020

Copy link
Copy Markdown

I forked this repo and have taken ownership from the original owner in npm. I've published an update to remove the unsafe components. If you would like this to be reviewed, please submit a PR into tjrexer/react-notifications:next.

thank you for keeping this alive. i tried your new lib. but i still get the same unsafe warnings in dev console. seems there is still one remaining called TransitionGroup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants