fix: correct register_xpu_ci args in DSA indexer XPU test (#24959) - #95
Draft
mingfeima wants to merge 24 commits into
Draft
fix: correct register_xpu_ci args in DSA indexer XPU test (#24959)#95mingfeima wants to merge 24 commits into
mingfeima wants to merge 24 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Ma Mingfei <mingfei.ma@intel.com>
register_xpu_ci() requires either suite= or stage=+runner_config=. The test used stage= alone with a suite-like string (and a suite/stage typo), which broke run_suite.py collection for all XPU suites. Co-authored-by: Ma Mingfei <mingfei.ma@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes the
run_suite.pycollection failure reported against sgl-project/sglang#24959:This branch is based on
Xia-Weiwen/glm5.1_enablingplus a one-line registration fix. Prefer cherry-picking the tip commit onto sgl-project#24959 rather than merging this whole branch if that PR remains the landing vehicle.Modifications
In
test/registered/xpu/test_dsa_indexer_xpu.py:register_xpu_ci(est_time=20, stage="suite-b-test-1-gpu-xpu")register_xpu_ci(est_time=20, suite="stage-b-test-1-gpu-xpu")register_xpu_ci()requires either legacysuite=or the(stage, runner_config)pair. Other XPU tests usesuite=. The previous call also had asuite-b/stage-btypo.Accuracy Tests
N/A — CI registration metadata only.
Speed Tests and Profiling
N/A
Checklist
CI States
Latest PR Test (Base): ❌ Run #29791733906
Latest PR Test (Extra): ❌ Run #29791733733