Skip to content

Update tên miền card2k.com -> card2k.net#75

Merged
amadeusmz merged 1 commit into
masterfrom
update-card2k
May 15, 2026
Merged

Update tên miền card2k.com -> card2k.net#75
amadeusmz merged 1 commit into
masterfrom
update-card2k

Conversation

@minhh2792
Copy link
Copy Markdown
Member

@minhh2792 minhh2792 commented May 11, 2026

Theo thông báo từ discord card2k:

image

@minhh2792 minhh2792 requested review from amadeusmz and Copilot May 11, 2026 18:17
@minhh2792 minhh2792 self-assigned this May 11, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

📝 Walkthrough

Walkthrough

The Card2KCP provider's API endpoint URL is updated to use the card2k.net domain instead of card2k.com for charging service requests. The method signature and all other logic remain unchanged.

Changes

API Endpoint Update

Layer / File(s) Summary
Card2K API Endpoint
dotman-plugin/src/main/java/net/minevn/dotman/providers/types/Card2KCP.kt
getApiUrl() returns https://card2k.net/chargingws/v2 instead of https://card2k.com/chargingws/v2.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop to the dot, a domain so neat,
From .com to .net, the migration's complete.
Card2K now charges with freshly typed care,
🐰 hops 'round rejoicing at endpoints so fair!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: updating the API endpoint domain from card2k.com to card2k.net, which matches the single file modification in this pull request.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-card2k

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
dotman-plugin/src/main/java/net/minevn/dotman/providers/types/Card2KCP.kt (1)

20-20: Consider the impact on in-flight transactions.

When deploying this change, be aware that any pending transactions (cards in "waiting" status) will start checking status against the new domain. Verify with Card2K support whether:

  • The old domain still processes status checks for transactions initiated on the old endpoint
  • Any special migration handling is needed for pending transactions
  • There's a recommended deployment timing or transition period
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@dotman-plugin/src/main/java/net/minevn/dotman/providers/types/Card2KCP.kt` at
line 20, You changed the API domain returned by getApiUrl() in Card2KCP.kt which
will make in-flight ("waiting") transactions be polled against the new endpoint;
before deploying, implement migration/compatibility handling: add a configurable
primary and fallback API URL (e.g. via env var) and update the status-checking
logic (the method that calls getApiUrl() / the status poller) to route checks
for transactions created before the cutover to the old domain (or to try old
domain on 404/timeouts), or add a migratePendingTransactions() routine to
explicitly re-query or reconcile waiting transactions; also add feature-flag or
deployment switch to flip to the new domain after confirming with Card2K
support.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@dotman-plugin/src/main/java/net/minevn/dotman/providers/types/Card2KCP.kt`:
- Line 20: You changed the API domain returned by getApiUrl() in Card2KCP.kt
which will make in-flight ("waiting") transactions be polled against the new
endpoint; before deploying, implement migration/compatibility handling: add a
configurable primary and fallback API URL (e.g. via env var) and update the
status-checking logic (the method that calls getApiUrl() / the status poller) to
route checks for transactions created before the cutover to the old domain (or
to try old domain on 404/timeouts), or add a migratePendingTransactions()
routine to explicitly re-query or reconcile waiting transactions; also add
feature-flag or deployment switch to flip to the new domain after confirming
with Card2K support.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d51ef67c-aefe-480e-92c8-c4fcadca53a7

📥 Commits

Reviewing files that changed from the base of the PR and between 6fadbfd and 7945ea1.

📒 Files selected for processing (1)
  • dotman-plugin/src/main/java/net/minevn/dotman/providers/types/Card2KCP.kt

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Cập nhật endpoint API của provider Card2K trong plugin DotMan để chuyển từ tên miền card2k.com sang card2k.net, مطابق theo thông báo từ Card2K.

Changes:

  • Thay đổi base API URL của Card2KCP sang https://card2k.net/chargingws/v2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amadeusmz amadeusmz merged commit e21e76f into master May 15, 2026
7 checks passed
@amadeusmz amadeusmz deleted the update-card2k branch May 15, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants