Update alert_contact.go to perform client-side filtering#8
Open
micahjsmith wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for the bug identified in #6
The getAlertContacts method on UptimeRobot public API has a bug and does not properly support filtering by alert contact id. However, we can easily implement this ourselves by filtering for the alert contact id from the response containing all the ids. https://uptimerobot.com/api/#getAlertContactsWrap
I will note that the code as written does not correctly handle the case where the user has more than 50 alert contacts since the API is paginated. I am not a go expert so would welcome feedback on whether addressing this limitation is in scope for this PR. For example, we could paginate over all the pages of alert contact responses and check if the desired id is present, failing only after the last page.