Mobile-187: Logger coverage#729
Merged
Merged
Conversation
MindboxLoggerTests was a manual PBXGroup, so each new test file required four hand-edited pbxproj entries. Convert it to a PBXFileSystemSynchronizedRootGroup (matching MindboxTests) so files added under the folder compile automatically.
Swift Testing suites covering MindboxError and the error/decodable models, the Logger/MBLogger facade, Core Data context helpers, log primitives, URL attributes and persistence internals; tags split by subsystem. Raises MindboxLogger framework line coverage from 54% to 91% via MindboxLoggerTests alone.
Convert LogStoreTrimmer/LoggerDatabaseLoader/MBLoggerCoreDataManager tests from XCTest to Swift Testing (async waits via continuations) and drop the two baseline-less measure perf tests. The manager suite is .serialized because its background-notification tests post to the global NotificationCenter that every manager observes — parallel execution would flip writesImmediately across tests. Adds a .trimming tag.
Stop FileManagerStoreURLTests deleting the shared Caches store (cross-suite flake under parallel run); make the LoggerPersistenceInternals setter round-trip assert a distinct value instead of a tautology; rename the assertion-free MBLogger tests as honest smoke tests; fix the .serialized rationale comment.
Convert both manual PBXGroups to PBXFileSystemSynchronizedRootGroups (matching MindboxTests/MindboxLoggerTests). MindboxNotificationsTests uses a generated Info.plist (GENERATE_INFOPLIST_FILE) like MindboxLoggerTests, so no membership exception is needed; TestPlans is target-less so schemes resolve plans by path.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
MindboxLoggerunit tests