fix: LC_ALL priority, empty lang filtering, and Windows arch detection#49
Merged
min0625 merged 1 commit intoJun 29, 2026
Merged
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
min0625
force-pushed
the
fix/locale-priority-empty-lang-filtering-and-install-arch
branch
4 times, most recently
from
e0dabd2 to
9c1f541
Compare
- Prioritize LC_ALL over LANG in getSystemLanguage (LC_ALL has higher precedence per POSIX) - Filter empty strings from MINT_TARGET_LANG so trailing/double commas are gracefully ignored - Fix install.ps1 arch detection to use PROCESSOR_ARCHITECTURE env var instead of RuntimeInformation.OSArchitecture - Add tests covering LC_ALL override and empty-segment filtering - Document security model (system/user separation + nonce) in READMEs and AGENTS.md Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
min0625
force-pushed
the
fix/locale-priority-empty-lang-filtering-and-install-arch
branch
from
9c1f541 to
66bbf9a
Compare
min0625
deleted the
fix/locale-priority-empty-lang-filtering-and-install-arch
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSystemLanguagenow checksLC_ALLbeforeLANG, matching POSIX precedence (LC_ALL overrides LANG)resolveTargetLangsnow ignores empty entries fromMINT_TARGET_LANG, so values likeen,oren,,zh-TWno longer produce blank language tagsscript/install.ps1switches fromRuntimeInformation.OSArchitectureto$env:PROCESSOR_ARCHITECTUREfor more reliable architecture detection; case strings updated fromX64/Arm64toAMD64/ARM64Test plan
make checkpasses (lint + tests)TestGetSystemLanguagecovers the newLC_ALL overrides LANG when both setcaseTestResolveTargetLangscoversconfig trailing comma ignoredandconfig double comma ignored🤖 Generated with Claude Code