Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .devcontainer/post_create.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,7 @@ mise trust .

mise install

mise exec -- go mod download

mise exec -- go install -v golang.org/x/tools/gopls@latest
mise exec -- go install -v github.com/go-delve/delve/cmd/dlv@latest
6 changes: 3 additions & 3 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
check:
name: Lint & Test
name: Check
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -21,5 +21,5 @@ jobs:
- name: Download Go dependencies
run: go mod download

- name: Run check (lint + test)
run: make check
- name: Run check
run: make check NEW_FROM_REV=origin/${{ github.base_ref }}
Comment thread
min0625 marked this conversation as resolved.
2 changes: 0 additions & 2 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ run:
timeout: 5m

issues:
new: true
whole-files: true
new-from-rev: HEAD~
max-same-issues: 50

severity:
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ make lint
make fix
# golangci-lint run -v --fix ./...

# Run lint + test together
# Run all checks
make check
```

Expand Down
12 changes: 9 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
NEW_FROM_REV ?= HEAD

fix:
golangci-lint run -v --fix ./...
go mod tidy
golangci-lint run -v --new-from-rev=$(NEW_FROM_REV) --fix ./...

lint:
golangci-lint run -v ./...
golangci-lint run -v --new-from-rev=$(NEW_FROM_REV) ./...
Comment thread
min0625 marked this conversation as resolved.

test:
go test -v -race -failfast ./...

check: lint test
check-tidy:
go mod tidy -diff

check: check-tidy lint test
Loading