Skip to content

fix: guard create rules on 2xx instead of name fallbacks #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ecv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: guard create rules on 2xx instead of name fallbacks #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/services/activity/policies/iam/group-policy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ spec:
# so controller reconciliation doesn't generate activity noise.
auditRules:
- name: create
match: "!audit.user.username.startsWith('system:') && audit.verb == 'create'"
summary: "{{ actor }} created group {{ has(audit.responseObject.metadata.name) ? link(audit.responseObject.metadata.name, audit.objectRef) : has(audit.objectRef.name) ? link(audit.objectRef.name, audit.objectRef) : (has(audit.responseObject.details) && has(audit.responseObject.details.name)) ? link(audit.responseObject.details.name, audit.objectRef) : link('a group', audit.objectRef) }}"
match: "!audit.user.username.startsWith('system:') && audit.verb == 'create' && audit.responseStatus.code >= 200 && audit.responseStatus.code < 300"
summary: "{{ actor }} created group {{ link(audit.responseObject.metadata.name, audit.objectRef) }}"

- name: delete
match: "!audit.user.username.startsWith('system:') && audit.verb == 'delete'"
Expand Down
4 changes: 2 additions & 2 deletions config/services/activity/policies/iam/role-policy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ spec:

auditRules:
- name: create
match: "!audit.user.username.startsWith('system:') && audit.verb == 'create'"
summary: "{{ actor }} created role {{ has(audit.responseObject.metadata.name) ? link(audit.responseObject.metadata.name, audit.objectRef) : has(audit.objectRef.name) ? link(audit.objectRef.name, audit.objectRef) : (has(audit.responseObject.details) && has(audit.responseObject.details.name)) ? link(audit.responseObject.details.name, audit.objectRef) : link('a role', audit.objectRef) }}"
match: "!audit.user.username.startsWith('system:') && audit.verb == 'create' && audit.responseStatus.code >= 200 && audit.responseStatus.code < 300"
summary: "{{ actor }} created role {{ link(audit.responseObject.metadata.name, audit.objectRef) }}"

- name: delete
match: "!audit.user.username.startsWith('system:') && audit.verb == 'delete'"
Expand Down
4 changes: 2 additions & 2 deletions config/services/activity/policies/iam/serviceaccount-policy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ spec:
# so controller reconciliation doesn't generate activity noise.
auditRules:
- name: create
match: "!audit.user.username.startsWith('system:') && audit.verb == 'create'"
summary: "{{ actor }} created service account {{ has(audit.responseObject.metadata.name) ? link(audit.responseObject.metadata.name, audit.objectRef) : has(audit.objectRef.name) ? link(audit.objectRef.name, audit.objectRef) : (has(audit.responseObject.details) && has(audit.responseObject.details.name)) ? link(audit.responseObject.details.name, audit.objectRef) : link('a service account', audit.objectRef) }}"
match: "!audit.user.username.startsWith('system:') && audit.verb == 'create' && audit.responseStatus.code >= 200 && audit.responseStatus.code < 300"
summary: "{{ actor }} created service account {{ link(audit.responseObject.metadata.name, audit.objectRef) }}"

- name: delete
match: "!audit.user.username.startsWith('system:') && audit.verb == 'delete'"
Expand Down
4 changes: 2 additions & 2 deletions config/services/activity/policies/resourcemanager/organization-policy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ spec:
# so controller reconciliation doesn't generate activity noise.
auditRules:
- name: create
match: "!audit.user.username.startsWith('system:') && audit.verb == 'create'"
summary: "{{ actor }} created organization {{ has(audit.responseObject.metadata.name) ? link(audit.responseObject.metadata.name, audit.objectRef) : has(audit.objectRef.name) ? link(audit.objectRef.name, audit.objectRef) : (has(audit.responseObject.details) && has(audit.responseObject.details.name)) ? link(audit.responseObject.details.name, audit.objectRef) : link('an organization', audit.objectRef) }}"
match: "!audit.user.username.startsWith('system:') && audit.verb == 'create' && audit.responseStatus.code >= 200 && audit.responseStatus.code < 300"
summary: "{{ actor }} created organization {{ link(audit.responseObject.metadata.name, audit.objectRef) }}"

- name: delete
match: "!audit.user.username.startsWith('system:') && audit.verb == 'delete'"
Expand Down
4 changes: 2 additions & 2 deletions config/services/activity/policies/resourcemanager/project-policy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ spec:
# so controller reconciliation doesn't generate activity noise.
auditRules:
- name: create
match: "!audit.user.username.startsWith('system:') && audit.verb == 'create'"
summary: "{{ actor }} created project {{ has(audit.responseObject.metadata.name) ? link(audit.responseObject.metadata.name, audit.objectRef) : has(audit.objectRef.name) ? link(audit.objectRef.name, audit.objectRef) : (has(audit.responseObject.details) && has(audit.responseObject.details.name)) ? link(audit.responseObject.details.name, audit.objectRef) : link('a project', audit.objectRef) }}"
match: "!audit.user.username.startsWith('system:') && audit.verb == 'create' && audit.responseStatus.code >= 200 && audit.responseStatus.code < 300"
summary: "{{ actor }} created project {{ link(audit.responseObject.metadata.name, audit.objectRef) }}"

- name: delete
match: "!audit.user.username.startsWith('system:') && audit.verb == 'delete'"
Expand Down
4 changes: 2 additions & 2 deletions config/services/identity/policies/serviceaccount-policy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ spec:
# so controller reconciliation doesn't generate activity noise.
auditRules:
- name: create
match: "!audit.user.username.startsWith('system:') && audit.verb == 'create'"
summary: "{{ actor }} created service account {{ has(audit.responseObject.metadata.name) ? link(audit.responseObject.metadata.name, audit.objectRef) : has(audit.objectRef.name) ? link(audit.objectRef.name, audit.objectRef) : (has(audit.responseObject.details) && has(audit.responseObject.details.name)) ? link(audit.responseObject.details.name, audit.objectRef) : link('a service account', audit.objectRef) }}"
match: "!audit.user.username.startsWith('system:') && audit.verb == 'create' && audit.responseStatus.code >= 200 && audit.responseStatus.code < 300"
summary: "{{ actor }} created service account {{ link(audit.responseObject.metadata.name, audit.objectRef) }}"

- name: delete
match: "!audit.user.username.startsWith('system:') && audit.verb == 'delete'"
Expand Down
Loading