feat: default --milo-kubeconfig and --leader-election-namespace to empty env vars#15
Merged
Merged
Conversation
…pty env vars Wire the two flags introduced in #13 into the base deployment using the same `$(VAR)` env-var substitution pattern that `METRICS_BIND_ADDRESS`, `HEALTH_PROBE_BIND_ADDRESS`, and `LEADER_ELECT` already follow: - Add `--milo-kubeconfig=$(MILO_KUBECONFIG)` and `--leader-election-namespace=$(LEADER_ELECTION_NAMESPACE)` to the manager args. - Default both env vars to empty strings so the manager keeps using the in-cluster client and controller-runtime's auto-detected lease namespace -- nothing changes for local development or for the bare-bundle install path. Downstream consumers that aggregate this controller into Milo (e.g. the datum-cloud/infra patch) can now override the manager's behaviour with a strategic merge on `env:` alone instead of copying the full `args:` list to add new flags.
JoseSzycho
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13 picking up review feedback from datum-cloud/infra#2383 (comment). Wires the two flags into the base deployment using the same
$(VAR)env-var substitution pattern thatMETRICS_BIND_ADDRESS,HEALTH_PROBE_BIND_ADDRESS, andLEADER_ELECTalready follow:--milo-kubeconfig=$(MILO_KUBECONFIG)and--leader-election-namespace=$(LEADER_ELECTION_NAMESPACE)to the manager args.Downstream consumers that aggregate this controller into Milo can now override the manager's behaviour with a strategic merge on
env:alone instead of copying the fullargs:list to add new flags. The companion infra patch in datum-cloud/infra#2383 is updated to match.kustomize build config/base/managerrenders the deployment with the two new args plus matching env defaults.