feat: mark Vendor and Subprocessor as Platform-context resources#14
Merged
Conversation
Adds the discovery.miloapis.com/parent-contexts=Platform annotation to the Vendor and Subprocessor CRDs so the Milo contextual discovery system classifies them as platform-level resources. Also fixes stale Makefile paths for controller-gen output and kustomize build targets. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mattdjenkinson
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discovery.miloapis.com/parent-contexts: Platformannotation to theVendorandSubprocessorCRDs (both the Go type markers and the generated YAML manifests)config/crd/bases→config/base/crd/basesfor controller-gen output, andconfig/crd→config/base/crdfor kustomize build targetsWhy Platform?
Both resources are authored and managed by the platform team, are cluster-scoped, and describe the platform's own third-party supply chain — not anything organization- or project-specific. This matches the
Platformcontext used byService,ServiceConfiguration,MeterDefinition, andMonitoredResourceTypeacross the Milo ecosystem.Test plan
make manifestsregenerates CRDs with thediscovery.miloapis.com/parent-contexts: Platformannotation present🤖 Generated with Claude Code