fix: correct DLQ runbook CEL null-check guidance#213
Closed
ecv wants to merge 1 commit into
Closed
Conversation
The documented remediation for cel_summary DLQ errors guarded only the root object (`has(audit.responseObject)`), which does not prevent `no such key: name` when responseObject is present but metadata.name is absent (DELETE, status subresource, and error/forbidden responses). Guard the full leaf path instead so the example actually fixes the failure it claims to. Refs #212 Key changes: - has(audit.responseObject.metadata.name) instead of has(audit.responseObject) - apply the same leaf-path guard to the spec.type DELETE example
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Correct the
cel_summaryremediation indocs/runbooks/dlq/policy-dlq-errors.md.The documented null check guarded only the root object
(
has(audit.responseObject)), which does not preventno such key: namewhenresponseObjectis present butmetadata.nameis absent (DELETE, statussubresource, error/forbidden responses). Guard the full leaf path instead.
Why
Surfaced by a prod
DLQSlowLeakongateway.networking.k8s.io-gateway(~120 Gateway audit events/6h to the DLQ). The runbook's suggested fix would
not have resolved it. See #212 for the full investigation.
Changes
has(audit.responseObject.metadata.name)instead ofhas(audit.responseObject)spec.typeDELETE exampleScope / does NOT fix prod
Docs only. The live leak is a standalone
ActivityPolicyCR(
gateway.networking.k8s.io-gateway) that is not version-controlled in thisrepo — see #212. Stopping the prod leak requires correcting that CR's rule 0
summary CEL; merging this PR does not do that on its own.
Refs #212