Merge v4-beta to v4 (2026-05-28)

[PaulNewling]

Merge v4-beta into v4

Greptile Summary

This PR merges v4-beta into v4, introducing a new changeset/check-coverage composite action that verifies every modified workspace package has a corresponding changeset entry, plus a fix-beta.sh helper and a hardened sed pattern in merge-beta.sh.

• New check-coverage action + bats test suite: cross-checks direct workspace-package edits and catalog version bumps against changeset status, exiting 1 on a gap and 2 on tooling failure; known named-catalog discriminator limitation is documented with a skipped test.
• fix-beta.sh: re-syncs v4-beta from v4; the two-pattern sed may silently miss @v4 refs followed by non-whitespace terminators.
• merge-beta.sh fix: replaces blanket s/@v4-beta/@v4/g with a pattern anchored to milaboratory/github-ci paths, preventing corruption of third-party action pins.

Confidence Score: 4/5

Safe to merge; the new check-coverage action and its test suite are well-constructed, and the merge-beta.sh sed fix correctly scopes rewrites to self-refs.

The core new feature and the merge-beta.sh fix are solid. fix-beta.sh two-pattern sed silently skips @v4 refs followed by non-whitespace terminators, and find commands traverse node_modules without pruning — both low-risk in practice but latent correctness gaps in a developer-facing maintenance script.

fix-beta.sh — the sed anchoring approach and find traversal scope warrant a second look before this script is used in anger.

Important Files Changed

Filename	Overview
actions/changeset/check-coverage/check-coverage.sh	New shell script implementing changeset coverage checking; well-structured with proper bash version guard, temp-file cleanup, and exit-code contract.
fix-beta.sh	New developer utility to re-sync v4-beta from v4; sed two-pattern approach misses refs followed by non-whitespace terminators; find traversal lacks node_modules pruning.
merge-beta.sh	Updated sed pattern now anchors @v4-beta replacement to milaboratory/github-ci self-refs only, preventing corruption of third-party action pins.
.github/workflows/node-simple-pnpm.yaml	Adds a diagnostic changeset-coverage job with continue-on-error: true so gaps surface as a red check without blocking merges.
actions/changeset/check-coverage/test/coverage.bats	Comprehensive bats test suite covering direct edits, catalog bumps, empty changesets, BASE_BRANCH parameterization, and tooling failures; known limitation skipped and documented.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[check-coverage.sh] --> B[changeset status - get bumped packages]
    B --> C{status.json non-empty?}
    C -- No and no-changesets msg --> D[bumped set is empty]
    C -- No and other error --> E[exit 2 tooling failure]
    C -- Yes --> F[build bumped set from releases]
    D --> G
    F --> G[pnpm filter list - get direct-edit packages]
    G --> H{pnpm-workspace.yaml changed?}
    H -- Yes --> I[yq: extract changed catalog keys via symmetric diff]
    I --> J[scan package.json files for catalog consumers]
    J --> K[add consumers to required set]
    K --> L
    H -- No --> L[compare required set vs bumped set]
    L --> M{any missing?}
    M -- None --> N[exit 0 - all covered]
    M -- Some --> O[print error per missing package then exit 1]

Loading

Prompt To Fix All With AI

Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
fix-beta.sh:80
**Sed patterns leave `@v4` refs followed by non-whitespace terminators unrewritten**

The two-pattern approach covers `@v4` at end-of-line (`\$`) and `@v4` followed by a whitespace character. However, it silently skips refs where `@v4` is followed by any other character — for example a `"` in a double-quoted YAML scalar, a `'` in single-quoted values, or `#` immediately adjacent to the tag without a space. Any such ref would remain as `@v4` on the v4-beta branch after `fix-beta.sh` runs. A single anchored pattern like `\([^[:alnum:]-]\|$\)` as the trailing boundary would close all of these cases in one expression instead of two.

### Issue 2 of 2
fix-beta.sh:75-78
**`find` traversal does not exclude `node_modules/` or `.git/`**

`find . -type f -name "action.yaml"` walks the entire working tree including `node_modules/` (present after any `pnpm install`) and `.git/`. While the anchored sed pattern prevents spurious rewrites, the traversal is unnecessary overhead. Adding `-not -path './node_modules/*' -not -path './.git/*'` would keep the scope tight. The same improvement applies to the equivalent call in `merge-beta.sh`.

_{Reviews (1): Last reviewed commit: "Merge v4-beta into v4" | Re-trigger Greptile}

Greptile also left 2 inline comments on this PR.