2 gin go templates htmx proof of concept - #3
Conversation
…ild in Makefile
mikequentel
changed the title
mikequentel
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d231cd318
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| logger.Info("migrations applied") | ||
| } | ||
| return nil | ||
| _ = r.Run(":8080") |
There was a problem hiding this comment.
The server startup call is assigned to _, so bind/listen failures (for example, port already in use or insufficient privileges) are silently ignored and main exits without surfacing the failure. This makes failed deployments harder to detect and troubleshoot because there is no error log or non-graceful failure path at startup.
Useful? React with 👍 / 👎.
|
|
||
| // HTMX: render only the <tbody> rows (used after create) | ||
| r.GET("/issues/rows", func(c *gin.Context) { | ||
| c.HTML(http.StatusOK, "issues.html", gin.H{ |
There was a problem hiding this comment.
This handler renders issues.html, but that file only defines the content template block and does not emit standalone output when executed directly, so /issues/rows responds with whitespace instead of issue rows. Any client that uses this endpoint to refresh table content will get an empty payload and fail to update the issue list.
Useful? React with 👍 / 👎.
1 participant
closes #2