Identify the disk storing the indices in nightly report HTML - #601
Merged
Conversation
…ightly report, follow-up to mikemccand#588.
neoremind
force-pushed
the
identify_index_disk
branch
from
July 21, 2026 02:16
dfc8afe to
0dc8268
Compare
mikemccand
approved these changes
Jul 21, 2026
mikemccand
left a comment
mikemccand
left a comment
Owner
There was a problem hiding this comment.
Awesome, thank you @neoremind -- I'll merge and let's watch for tomorrow's report of tonite's run!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #588, the nightly report should show the specific disk storing the indices (e.g.,
constants.INDEX_DIR_BASE), currently it lists every block device on the machine.How it works:
get_disk_info()now accepts an optional givenpath, it attempts to resolve the disk backing that path where the index is stored. It usesdf --output=source <path>to find the filesystem source device, then useslsblk -lsno NAME,TYPE,SIZE,MODEL <device>and keeps only disk-typed items. If there is no path specified or the path doesn't exist, just fall back to original listing all devices path. For non-block filesystems (NFS, tmpfs, overlayfs), reports thedfsource string, for examplenas:/export/bench.Tested on my EC2 with SSD.
/home/ec2-user/index, it shows8G Amazon Elastic Block Store69.8G Amazon EC2 NVMe Instance Storage.