Def mode to prevent duplicate listeners per topic - #123
Open
mig82 wants to merge 1 commit into
Open
Conversation
mig82
added a commit
to mig82/kronin
that referenced
this pull request
Jul 31, 2019
This is based on my fork of AmplifyJS and PR [here](mikehostetler/amplify#123)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found myself in situations where the same listener gets added more than once due to the navigation flows of an application. This causes the
subscriptionsmap to grow without control.This change allows the developer to change the behaviour so that
subscribecan be idempotent. Meaning that adding the same listener more than once to a topic only really adds it the first time.