More flexible handling of expires option in amplify.store - #105
Open
SteveTheTechie wants to merge 1 commit into
Open
More flexible handling of expires option in amplify.store#105SteveTheTechie wants to merge 1 commit into
SteveTheTechie wants to merge 1 commit into
Conversation
It would be nice to be able to just use {expires: "never"} or a specific date, and let amplify store figure out the details. My proposed changes allow for this via a small function that checks if expires is a string and then does the appropriate conversion to a millisecond offset. I used a function for this to keep the existing code "clean" and allow for other possible keywords for "expires" to be added to the function.
Author
There was a problem hiding this comment.
Use a small function to encapsulate handling of strings specified for the expires option.
SteveTheTechie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to be able to just use {expires: "never"} or a specific date, and let amplify store figure out the details. My proposed changes allow for this via a small function that checks if expires is a string and then does the appropriate conversion to a millisecond offset. I used a function for this to keep the existing code "clean" and allow for other possible keywords for "expires" to be added to the function.