Skip to content

solve interpolation issue #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
merlosy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solve interpolation issue #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf2935d
solve interpolation issue
merlosy Jul 17, 2015
68cce8e
fixed typo issue
merlosy Jul 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions lib/angular-piwik.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,11 @@ mod.factory 'Piwik', [
mod.directive 'ngpPiwik', [
'$window'
'$document'
'$interpolate'
'Piwik'
'PiwikActionMethods'

($window, $document, Piwik, PiwikActionMethods) ->
($window, $document, $interpolate, Piwik, PiwikActionMethods) ->
$window['_paq'] = $window['_paq'] || []
arr_param_methods = [
'setDomains'
Expand Down Expand Up @@ -158,11 +159,12 @@ mod.directive 'ngpPiwik', [
replace: no
transclude: yes
compile: (tElement, tAttrs, transclude) ->
script_elem = $document[0].createElement 'script'
script_elem.setAttribute 'src', tAttrs.ngpSetJsUrl
$document[0].body.appendChild script_elem

return {
pre: (scope, elem, attrs) ->
script_elem = $document[0].createElement 'script'
src = $interpolate(tAttrs.ngpSetJsUrl) scope
script_elem.setAttribute 'src', src
$document[0].body.appendChild script_elem
post: (scope, elem, attrs) ->
for own k,v of attrs when /^ngp/.test(k)
do (k,v) ->
Expand Down