Small Improvement - #1
Open
jstrouse wants to merge 7 commits into
Open
Conversation
…ackground and foreground colors to be selected.
…stead of using multiple ones. Has better behavior with other plugins (i.e. font-family and font size) and creates less span tags.
…n undo point and change the cursor so that it looks like you selecting something
…ndle the fact that the aloha button class may be a child of the span clicked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is an improvement over what you have as both background and foreground colors can be selected at the same time. Still room to improve the logic yet.