[#75] Improve item drop system#95
Merged
Merged
Conversation
Signed-off-by: Mihai Dumitrescu <mihairazvand1@gmail.com>
Signed-off-by: Mihai Dumitrescu <mihairazvand1@gmail.com>
mihaid11
force-pushed
the
mihai/item_drop_issue
branch
from
0d16b17 to
2d0d00b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
[#75] Improve item drop system
Description
What changes did you make?
Added a function that calculates the drop position gradually until a collision with an entiy or maximum distance is reached.
Why are these changes needed?
Dropped item position was just an offset from the character position, neglecting game entities, which resulted in items going through entities.
Related Issue:
Fixes #75
Type of Change
Checklist