Skip to content

Add unit tests for transfer-pvc Progress and dataSize types & fixed typo #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RanWurmbrand wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add unit tests for transfer-pvc Progress and dataSize types & fixed typo #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e61964
Add unit tests for transfer-pvc Progress and dataSize types
RanWurmbrand May 6, 2026
d61af4e
Fix retryRegex typo: Syncronization -> Synchronization The regex patt…
RanWurmbrand May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/transfer-pvc/progress.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ func parseRsyncLogs(rawLogs string) (p *Progress, unprocessedData string) {
finalFileCountRegex := regexp.MustCompile(`Number of regular files transferred: (.*)`)
unprocessedLines := regexp.MustCompile(`.*?\n(.*)$`)
// retries
retryRegex := regexp.MustCompile(`Syncronization failed. Retrying in \d+ seconds. Retry (\d+)/.*`)
retryRegex := regexp.MustCompile(`Synchronization failed. Retrying in \d+ seconds. Retry (\d+)/.*`)

@stillalearner stillalearner May 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change depends on the backube/pvc-transfer logging, can you please check if the correct spelling is logged there as well?

@RanWurmbrand RanWurmbrand May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked that before hand, it is spelled correctly over there :)

https://github.com/backube/pvc-transfer/blob/main/transfer/rsync/client.go#L351


inProgressLines := fileProgressRegex.FindAllStringSubmatch(rawLogs, -1)
for _, matched := range inProgressLines {
Expand Down
Loading
Loading