Adjust delta calculations based on new origin and scale#139
Open
marco00petrucci wants to merge 1 commit into
Open
Adjust delta calculations based on new origin and scale#139marco00petrucci wants to merge 1 commit into
marco00petrucci wants to merge 1 commit into
Conversation
Owner
|
Thanks for your contribution, @marco00petrucci Would be nice, if you share your video. Right now, I don't understand the jump/glitch for pan after zoom. |
Author
|
Try zooming in and out into the corner of an image with your mouse and you'll see it doesn't work right: |
Owner
|
Okies, let me reproduce it locally with and without your patch. I'll check back then! |
Owner
|
D'oh, I forgot to test your changes and put it in current release. Please be patient :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When zooming an image, the
transform-originis updated, butdeltaXanddeltaYare not compensated for this shift. This causes the image to jump/glitch when trying to pan it right after zooming.Fix
Added a mathematical compensation for the
transform-originshift inside thezoomPanfunction, just before callingpan(deltaX, deltaY). I also have a video of the bug if needed.