Support application/javascript MIME type for JS minification#10
Open
carlosmintfan wants to merge 1 commit into
Open
Support application/javascript MIME type for JS minification#10carlosmintfan wants to merge 1 commit into
carlosmintfan wants to merge 1 commit into
Conversation
The WHATWG MIME Sniffing Standard lists both text/javascript and application/javascript as valid JavaScript MIME types. Changed the property to (array) so Minifier::js() matches both, ensuring responses with Content-Type: application/javascript are also minified. Closes middlewares#9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WHATWG MIME Sniffing Standard lists both
text/javascriptandapplication/javascriptas valid JavaScript MIME types. Browsers and servers commonly use either.Changes:
$mimetype(string) →$mimetypes(string[]) to support multiple MIME types per compressorMinifier::js()now matches bothtext/javascriptandapplication/javascriptprocess()to loop through all configured MIME typesapplication/javascriptcontent typeCloses #9