Avoid double-sending Fastify replies in @orpc/nest#1558
Draft
Copilot wants to merge 4 commits into
Draft
Conversation
Deploying orpc with
|
| Latest commit: |
b85f218
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://503a57d4.orpc-4zt.pages.dev |
| Branch Preview URL: | https://copilot-fix-fst-err-rep-alre.orpc-4zt.pages.dev |
Copilot
AI
changed the title
[WIP] Fix FST_ERR_REP_ALREADY_SENT for Nest with FastifyAdapter
Avoid double-sending Fastify replies in May 18, 2026
@orpc/nest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
@orpc/nestwith Nest'sFastifyAdaptercould triggerFST_ERR_REP_ALREADY_SENTon successful oRPC routes. The response was being written by oRPC and then sent again by Nest's normal Fastify response pipeline.Fastify response handling
ImplementInterceptorto prepare the reply onFastifyReplyand return the serialized body to Nest, instead of callingsendStandardResponse(...)directly.sendResponseInterceptorsthat intentionally take over response sending/return behaviorRegression coverage
Reply was already sentwarning.Behavioral impact
@Implement(...)routes on Fastify now flow through a single send path.