Drop vestigial -1.0 suffix from vendor/DirectX-Headers-1.0#1451
Open
benhillis wants to merge 1 commit into
Open
Drop vestigial -1.0 suffix from vendor/DirectX-Headers-1.0#1451benhillis wants to merge 1 commit into
benhillis wants to merge 1 commit into
Conversation
Use 'vendor/DirectX-Headers' as the canonical path, matching the upstream repo name (https://github.com/microsoft/DirectX-Headers). The '-1.0' suffix was vestigial from an old multi-version-coexistence convention that no longer applies; only one version is ever vendored. Touches build-and-export.sh, Dockerfile, CONTRIBUTING.md, config/BUILD.md. Paired with wslg-build PR that materialises both old and new paths in the pipeline so neither this rename nor older wslg refs (release/*) break in the merge gap. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the obsolete -1.0 suffix from the DirectX-Headers vendor directory name, standardizing on vendor/DirectX-Headers and updating all in-repo build/documentation references accordingly.
Changes:
- Update Docker build steps to
COPY/WORKDIRfromvendor/DirectX-Headers. - Update local build helper (
build-and-export.sh) to read the DirectX-Headers commit from the new path. - Update contributor/self-hosting documentation to use the new vendor directory name.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Dockerfile | Switches DirectX-Headers build inputs to vendor/DirectX-Headers. |
| CONTRIBUTING.md | Updates clone and build-arg instructions to reference wslg/vendor/DirectX-Headers. |
| config/BUILD.md | Updates tarball extraction rename step to produce vendor/DirectX-Headers. |
| build-and-export.sh | Updates vendor_commit path for DirectX-Headers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-1.0suffix onvendor/DirectX-Headers-1.0is a vestige of a one-time experimental upgrade attempt. We only ship the one version of DirectX-Headers, so the suffix is dead version-skew baggage that's been confusing every new contributor opening the Dockerfile.Rename to
vendor/DirectX-Headersand update the 4 referencing files: Dockerfile (COPY + WORKDIR), build-and-export.sh (vendor_commitcall), CONTRIBUTING.md (3 references in setup recipes), config/BUILD.md (mv command).Merge order matters -- the companion bridge PR in wslg-build must merge first. The bridge materializes both the old and new vendor paths so wslg main + every
release/*branch keeps building unchanged. After this PR lands and any maintained release branches have adopted the new name, a follow-up wslg-build PR can drop the bridgecp -aline.Companion: https://github.com/microsoft/wslg-build/pull/new/user/benhillis/dxh-rename-bridge (link will redirect to the actual PR once filed)
Buddy: https://microsoft.visualstudio.com/DxgkLinux/_build/results?buildId=147259999 (paired wslg=this PR + wslg-build=
user/benhillis/dxh-rename-bridge)